ENHACEMENTS: ManageSieve capabilities #2916
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
force-pushed
the
managesieve-enhancements
branch
from
ef3bc52 to
f6a9194
Compare
…gociation and Auth
Contributor
Author
|
Please @felixauringer have a look to those managesieve bugs reported privately to the PMC |
chibenwa
force-pushed
the
managesieve-enhancements
branch
from
0098e29 to
35a7cec
Compare
Arsnael
approved these changes
Jan 29, 2026
Contributor
|
I can have a look today. |
felixauringer
approved these changes
Jan 29, 2026
Contributor
felixauringer
left a comment
felixauringer
left a comment
There was a problem hiding this comment.
I only compared the changes to the RFC (did not test locally) and that looked fine 👍
| } | ||
|
|
||
| public static final String IMPLEMENTATION_DESCRIPTION = "Apache ManageSieve v1.0"; | ||
| public static final String IMPLEMENTATION_DESCRIPTION = "Apache James ManageSieve 3.9.0"; |
Contributor
There was a problem hiding this comment.
I definitely see why you put the version here but maybe it would be nice to have it as a constant somewhere? Changing it here (and probably in other places) and in many tests for every version seems cumbersome to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.