Skip to content

Conversation

@quantranhong1999
Copy link
Member

No description provided.

Copy link
Contributor

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for the technical capabilities,

Not ok for the API interface side that needs rework ^^

Copy link
Contributor

@Arsnael Arsnael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read it!

@quantranhong1999
Copy link
Member Author

Not ok for the API interface side that needs rework ^^

What do you suggest then? If it is SearchOption POJO cf linagora#5506, should we refactor the API interface in another PR?

@chibenwa
Copy link
Contributor

chibenwa commented Jan 28, 2026

Not adding a MailboxManager method that's for sure.

should we refactor the API interface in another PR?

I'd prefer the refactorings to be a preliminary work actually

Also we said collapseThread should be a property of SearchQuery POJO, and Let's use a collapse for messageId dedup

I think the changeset would be easier with those.

Suggestion:

  • Start 1. by using collapse for email Id and drop scroll for JMAP
  • Second 2. Modify the search API with SearchOptions and push the offsets onto the search engine
  • Third 3. add collapseTHread options onto Search query, implement openSearch, with search enging low level tests
  • Fourth 4. Expose this fully onto the JMAP layer

4 small incremental steps that each individually adds value.

Opinion @quantranhong1999 ?

@quantranhong1999
Copy link
Member Author

I'd prefer the refactorings to be a preliminary work actually

Ok to me.

Start 1. by using collapse for email Id and drop scroll for JMAP
Second 2. Modify the search API with SearchOptions and push the offsets onto the search engine

I would focus on refactoring these first in another PR, and come back to rework this OpenSearch PR later then.

@quantranhong1999 quantranhong1999 marked this pull request as draft January 28, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants