MINOR: Add a build image based on the official Hugo release binary#885
Open
Owen-CH-Leung wants to merge 2 commits into
Open
MINOR: Add a build image based on the official Hugo release binary#885Owen-CH-Leung wants to merge 2 commits into
Owen-CH-Leung wants to merge 2 commits into
Conversation
Add a local build image (Dockerfile.hugo-builder) that installs the official Hugo extended release binary from the Hugo project, alongside the Node.js/PostCSS and Go toolchains the Docsy theme needs. Unlike the current build image, it does not depend on any externally-hosted or personal image (e.g. hvishwanath/hugo). This is added as a separate, opt-in path, so no CI behaviour or deployment changes in this PR: - CI: the "Build and Deploy Site" workflow runs `make build`, which is left unchanged and still uses the current image. The published website is not affected. - Local: `make build-official` builds the new image from the official binary and renders the site with it. Its output is byte-for-byte identical to `make build` (verified: 28,139 files, identical SHA-256). The goal is to validate the official-binary image first; switching the build and CI over to it can follow in a later change.
Author
|
Instead of using the official hugo image, I've built the image from alpine and download the hugo binary v0.123.7. This is because the official image isn't published for 0.123.7 (its oldest tags are 0.135) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a local build image
Dockerfile.hugo-builderthat installs the official Hugo extended release binary from the Hugo project, alongside the other required binaries such as theNode.js,PostCSSand Go toolchains .Unlike the current build image, it does not depend on any externally-hosted or personal image (e.g. hvishwanath/hugo).
This is added as a separate, opt-in path, so no CI behaviour or deployment changes in this PR:
make build, which is left unchanged and still uses the current image. The published website is not affected.make build-officialbuilds the new image from the official binary and renders the site with it. Its output is byte-for-byte identical tomake buildThe goal is to validate the official-binary image first; switching the build and CI over to it can follow in a later change.