Skip to content

KAFKA-18952: Fix flaky test in MonitorableSinkIntegrationTest #21057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
majialoong wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

KAFKA-18952: Fix flaky test in MonitorableSinkIntegrationTest #21057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions ...me/src/test/java/org/apache/kafka/connect/integration/MonitorableSinkIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ public class MonitorableSinkIntegrationTest {
private static final int NUM_TASKS = 1;
private static final long CONNECTOR_SETUP_DURATION_MS = TimeUnit.SECONDS.toMillis(60);
private static final long CONSUME_MAX_DURATION_MS = TimeUnit.SECONDS.toMillis(30);
private static final long METRICS_CONVERGENCE_DURATION_MS = TimeUnit.SECONDS.toMillis(5);

private EmbeddedConnectStandalone connect;
private ConnectorHandle connectorHandle;
Expand Down Expand Up @@ -119,11 +120,19 @@ public void testMonitorableSinkConnectorAndTask() throws Exception {

// check task metric
metrics = connect.connectMetrics().metrics().metrics();
MetricName taskMetric = MonitorableSinkConnector.MonitorableSinkTask.metricsName;
assertTrue(metrics.containsKey(taskMetric));
assertEquals(CONNECTOR_NAME, taskMetric.tags().get("connector"));
assertEquals("0", taskMetric.tags().get("task"));
assertEquals((double) NUM_RECORDS_PRODUCED, metrics.get(taskMetric).metricValue());
MetricName taskMetricName = MonitorableSinkConnector.MonitorableSinkTask.metricsName;
assertTrue(metrics.containsKey(taskMetricName));
assertEquals(CONNECTOR_NAME, taskMetricName.tags().get("connector"));
assertEquals("0", taskMetricName.tags().get("task"));

KafkaMetric taskMetric = metrics.get(taskMetricName);
// The metric value may not be updated immediately after awaitRecords() returns,
// because MonitorableSinkTask.count is incremented after TestableSinkTask.put()
// which triggers the latch countdown. Use waitForCondition to handle this race condition.
waitForCondition(
() -> (double) NUM_RECORDS_PRODUCED == (double) taskMetric.metricValue(),
METRICS_CONVERGENCE_DURATION_MS,
"Task metric did not converge to expected value in time.");

connect.deleteConnector(CONNECTOR_NAME);
connect.assertions().assertConnectorDoesNotExist(CONNECTOR_NAME,
Expand All @@ -132,7 +141,7 @@ public void testMonitorableSinkConnectorAndTask() throws Exception {
// verify connector and task metrics have been deleted
metrics = connect.connectMetrics().metrics().metrics();
assertFalse(metrics.containsKey(connectorMetric));
assertFalse(metrics.containsKey(taskMetric));
assertFalse(metrics.containsKey(taskMetricName));
}

/**
Expand Down