KAFKA-20796: Fix num-open-iterators metric for timestamped range queries#22809
Open
dino2895 wants to merge 1 commit into
Open
KAFKA-20796: Fix num-open-iterators metric for timestamped range queries#22809dino2895 wants to merge 1 commit into
dino2895 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MeteredTimestampedKeyValueStoreIteratorregistered itself inopenIterators, but did not updatenumOpenIterators. As a result,iterators created by IQv2
RangeQueryandTimestampedRangeQuerywere not included in the
num-open-iteratorsmetric.This change increments the counter when the iterator is created and
decrements it when the iterator is closed.
Regression tests verify that the metric transitions from 0 to 1 while
the iterator is open and returns to 0 after it is closed for both query
types.
Testing:
./gradlew :streams:spotlessJavaCheck./gradlew :streams:checkstyleMain :streams:checkstyleTest./gradlew :streams:test