Skip to content

add analytics script#5

Open
ayhamthemayhem wants to merge 3 commits intoapache:mainfrom
neighbourhoodie:add-analytics-script
Open

add analytics script#5
ayhamthemayhem wants to merge 3 commits intoapache:mainfrom
neighbourhoodie:add-analytics-script

Conversation

@ayhamthemayhem
Copy link
Copy Markdown

Hey there,

This is part of our work at Neighbourhoodie/ with STF's Bug Resilience Program for Log4j.

This is a PR to add a script file that can be loaded into other logging websites to load matomo analytics scripts for website based on if they are dormant or active.

I used an example of a matomo script that we found here

Do you maybe have an example of what a matomo script for dormant websites looks like ?

@rgoers
Copy link
Copy Markdown
Member

rgoers commented Oct 23, 2024

Why would you skip dormant projects? At some point flume will be coming back into the fold and I won't want to remember to have to modify this.

@grobmeier It looks like you added a link to analytics.apache.org? What is that?

@ppkarwasz
Copy link
Copy Markdown
Contributor

@ayhamthemayhem,

Could you also remove Matomo from footer.html and add a reference to your script to header.html?

I don't think there should be a difference between dormant and active subproject. Maybe we could add some custom dimension, but I don't know what would make sense.
Certainly, for GDPR reasons we need to ask user for their consent to track them (see managing consent). That fact must have slipped our mind when we added Matomo. @grobmeier, am I right?

@rgoers,

analytics.apache.org contains an on premises installation of the Matomo tracking software. It should be useful to track the popularity of pages and also find out the 404 errors.

@ayhamthemayhem
Copy link
Copy Markdown
Author

ayhamthemayhem commented Oct 30, 2024

Why would you skip dormant projects? At some point flume will be coming back into the fold and I won't want to remember to have to modify this.

Hey, dormant projects are not skipped they just have a different script than others but that is also still unclear and up to discussing which projects go to which array but and that is up to the log4j team to decide.

@ayhamthemayhem
Copy link
Copy Markdown
Author

ayhamthemayhem commented Oct 30, 2024

Could you also remove Matomo from footer.html and add a reference to your script to header.html?

done !

@ayhamthemayhem
Copy link
Copy Markdown
Author

If there is a list or more info on which websites are dormant or skipped that would be great.
I would adjust the PR quickly as needed :)

Copy link
Copy Markdown
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me,
but I would wait for a review of our V.P. Data Privacy (@grobmeier) before merging it. 😉

@ppkarwasz ppkarwasz requested a review from grobmeier March 19, 2025 10:08
Copy link
Copy Markdown
Member

@grobmeier grobmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
However, the site was migrated to Antora, and _includes no longer exists.
I cannot tell if this change would work anymore.
I'd like to ask @vy or @ppkarwasz to check this PR against Antora.

@vy
Copy link
Copy Markdown
Member

vy commented Mar 29, 2026

@grobmeier, you're right. Indeed the PR needs to be adapted for the most recent (Antora et al.) changes in main. I'd suggest closing this PR (since it is targeting the old Jekyll setup) and asking the author, if they are still interested in, submitting a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants