feat: auto-source config metadata and simplify CI check mapping#859
Merged
Conversation
potiuk
approved these changes
Jul 14, 2026
potiuk
left a comment
Member
There was a problem hiding this comment.
Nice one ! Thanks @onlyarnav !
Member
|
I will add one thing though as a fix-up to make the .asf.yaml only used for ASF projects. |
The auto-sourcing in this PR read .asf.yaml and defaulted mailing lists to *.apache.org unconditionally, breaking vendor-neutrality for independent (non-ASF) adopters. Split the Step 4b auto-sourced fields into organization-agnostic (upstream_repo, upstream_default_branch, product_family_url, labels — from gh repo view, for any adopter) and ASF-specific (.asf.yaml mailing lists + apache.org defaults — only when organization: ASF). Apply the same gate in adopt Step 9 pre-populate, upgrade Step 6g drift reconciliation, verify 8f drift check, and the project.md template notes; a non-ASF organization leaves the mailing-list fields as TODO rather than inventing apache.org addresses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upstream_repo,upstream_default_branch,product_family_url, topics/labels, and mailing lists (dev_list,commits_list,users_list,private_list,security_list,announce_list) from.asf.yamland repository metadata viagh repo view, minimizing configuration duplication.pr-management-triage-ci-check-map.mdoptional and collapse its default template table to a single catch-all pointer (upstream_contributing_docs_url), simplifying the setup and reducing maintenance burden..asf.yamlor repository metadata, allowing in-place reconciliation.Type of change
.claude/skills/<name>/) — setup (adopt,upgrade,verify) andpr-management-triageskills updated.tools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses (115 tests passed intools/skill-evals/tests/)prek run doctoc --all-filesto verify TOC generation (passed). Manually ran license header verificationtools/dev/add-license-headers.pyon all changed files (passed).RFC-AI-0004 compliance
<PROJECT>,<tracker>,<upstream>,<security-list>) used in all modified files.Linked issues
#815
Notes for reviewers (optional)
The
prek run --all-filescommand hit compilation issues locally due to missing MSVC cargo compiler dependency (lycheelink checker compilation error) and python shell alias on the Windows testing host. Formatting and licence headers were verified manually and through individual prek hooks (doctoc), all passing successfully.