Skip to content

Enable Maven 4 #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cstamas merged 2 commits into from
Jun 30, 2026
Merged

Enable Maven 4 #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9be59d0
Enable Maven 4
cstamas Jun 30, 2026
fa1f561
Drop irrelevant change; this is Maven issue
cstamas Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/maven-verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ jobs:
build:
name: Verify
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v4
with:
maven4-enabled: true
2 changes: 2 additions & 0 deletions src/it/projects/active-profiles_multimodule/invoker.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,5 @@
# under the License.

invoker.goals = ${project.groupId}:${project.artifactId}:${project.version}:active-profiles
# not on Maven 4 until fixed https://github.com/apache/maven/issues/12405

@hboutemy hboutemy Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's ignore this active-profiles_multimode IT while apache/maven#12405 is being fixed (in Maven 4.0.0-RC-6 I hope)

invoker.maven.version = 4-
9 changes: 2 additions & 7 deletions src/it/projects/describe-cmd/verify.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,8 @@ def result = new File(basedir, 'result-deploy.txt').text;

def ls = System.getProperty( "line.separator" );

// used deprecated methods - FIXME in DescribeMojo
if (mavenVersion.startsWith('4.')) {
assert result.contains("'deploy' is a phase within the 'default' lifecycle, which has the following phases:")
} else {
assert result.contains("'deploy' is a phase corresponding to this plugin:" + ls +
"org.apache.maven.plugins:maven-deploy-plugin")
}
assert result.contains("'deploy' is a phase corresponding to this plugin:" + ls +
"org.apache.maven.plugins:maven-deploy-plugin")

result = new File(basedir, 'result-site.txt').text;

Expand Down
6 changes: 3 additions & 3 deletions src/it/projects/evaluate-forceStdout/invoker.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.

invoker.goals = ${project.groupId}:${project.artifactId}:${project.version}:evaluate -q
invoker.goals = ${project.groupId}:${project.artifactId}:${project.version}:evaluate -q --raw-streams
invoker.debug = false
# for Maven 4 we need --raw-streams
invoker.maven.version = 4-
# we need --raw-streams (supported since 3.9.10+)
invoker.maven.version = 3.9.10+
Loading