Skip to content

Appending a trailing delimiter for Markdown table formatting#1592

Merged
slawekjaranowski merged 1 commit into
apache:masterfrom
slawekjaranowski:update-format
Jul 13, 2026
Merged

Appending a trailing delimiter for Markdown table formatting#1592
slawekjaranowski merged 1 commit into
apache:masterfrom
slawekjaranowski:update-format

Conversation

@slawekjaranowski

Copy link
Copy Markdown
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Run mvn site and examine output in target/site directory.
    Site will also be built on your pull request automatically and attached to GitHub Action result.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski
slawekjaranowski requested a review from hboutemy May 30, 2026 11:33
@slawekjaranowski slawekjaranowski added the bug Something isn't working label May 30, 2026
@hboutemy

Copy link
Copy Markdown
Member

what problem is being solved?

@slawekjaranowski

Copy link
Copy Markdown
Member Author

what problem is being solved?

We have missing last | at markdown table

@hboutemy

Copy link
Copy Markdown
Member

it's a choice I did years ago, no need to complexify

@slawekjaranowski

Copy link
Copy Markdown
Member Author

it's a choice I did years ago, no need to complexify

so we should remove all ending | from tables in markdown documets?

Now we have mixed some lines are with | and some not .... at the end.

https://raw.githubusercontent.com/apache/maven-site/refs/heads/master/content/markdown/plugins/index.md

image

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the org.apache.maven.site.update.Update helper so that when it rewrites a Markdown table row (after detecting an updated release version/date), the regenerated row ends with a trailing |, preserving/ensuring consistent Markdown table formatting.

Changes:

  • Append a trailing pipe (|) when rebuilding an updated Markdown table line.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@slawekjaranowski
slawekjaranowski merged commit 5f537f4 into apache:master Jul 13, 2026
1 check passed
@slawekjaranowski
slawekjaranowski deleted the update-format branch July 13, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants