Make LookupContext#closeables thread safe (backport to 4.0.x)#12414
Merged
gnodet merged 1 commit intoJul 3, 2026
Merged
Conversation
This collection is modified by multiple threads, e.g. the FastTerminal setup thread calling context.closeables.add(out::flush). This can result in closeables being lost and can make subsequent builds with the embedded runner fail. Signed-off-by: Stefan Oehme <st.oehme@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12411 to
maven-4.0.x.This collection is modified by multiple threads, e.g. the FastTerminal setup thread calling
context.closeables.add(out::flush). This can result in closeables being lost and can make subsequent builds with the embedded runner fail.Cherry-picked from c48ad20 (master).