[MNG-8432] Inherit properties from imported BOMs#12417
Open
Hiteshsai007 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[MNG-8432] Inherit properties from imported BOMs
Description
This PR resolves MNG-8432 (also referenced as #10196 on GitHub), which adds the capability to inherit properties from imported BOMs.
Previously, when a child project imported a BOM using
<dependencyManagement>with<scope>import</scope>, Maven only extracted and merged the<dependencyManagement>sections. The<properties>block of the BOM was entirely ignored. This limitation forced users to manually duplicate property definitions (e.g., version placeholders) in their consuming POMs to use them in plugins or standard dependencies.Changes in this PR:
DefaultModelBuilder.loadBomModelto fetch and return the complete resolvedModelof the BOM rather than just theDependencyManagementobject.importDependencyManagementto collect the properties from all imported BOM models and merge them into the consuming model. The consuming model's existing properties take precedence, preventing unwanted overrides.importDependencyManagementruns after the initial model interpolation pass (readEffectiveModel), added a second pass ofinterpolateModel(resultModel, request, this)immediately after importing the properties. This correctly substitutes BOM properties into the unresolved placeholders (e.g.,<version>${lib.version}</version>) within the model.Checklist