Skip to content

NIFI-15153: Fix UI overflow by allowing long names to wrap in connect… #10709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swatiksi273-ksolves wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

NIFI-15153: Fix UI overflow by allowing long names to wrap in connect… #10709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...connection/destination/destination-process-group/destination-process-group.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
<div class="flex flex-col mb-5" data-qa="error-section">
<div data-qa="to-input-error-label">To Input</div>
@if (noPorts) {
<mat-error data-qa="no-ports-error">{{ groupName }} does not have any local input ports.</mat-error>
<mat-error data-qa="no-ports-error" class="tertiary-color break-words font-medium w-full">{{ groupName }} does not have any local input ports.</mat-error>
Copy link
Contributor

@scottyaslan scottyaslan Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add tertiary-color or font-medium to mat-error components. These a colored via angular material theme and follow the typography we have defined for the entire application.

We also do not need the break-words or w-full here. Please revert this change.

}
@if (hasUnauthorizedPorts) {
<mat-error data-qa="unauthorized-ports-error"
<mat-error data-qa="unauthorized-ports-error" class="tertiary-color break-words font-medium w-full"
>Not authorized for any local input ports in {{ groupName }}</mat-error
>
}
Expand Down Expand Up @@ -54,7 +54,7 @@
<div data-qa="within-group-label">Within Group</div>
<div
[title]="groupName"
class="tertiary-color overflow-ellipsis overflow-hidden whitespace-nowrap font-medium"
class="tertiary-color break-words font-medium w-full"
Copy link
Contributor

@scottyaslan scottyaslan Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the overflow-ellipsis overflow-hidden whitespace-nowrap in this case. Here we should follow established UX patterns which in this case would mean the text should have either the overflow-ellipsis overflow-hidden whitespace-nowrap or the truncated tailwind classes applied with a title attribute (which I see is already present in the template).

data-qa="group-name-display">
{{ groupName }}
</div>
Expand Down
Loading