NIFI-15474 Support timestamp truncation in RecordPath DSL #10796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvillard31
reviewed
Jan 30, 2026
Contributor
pvillard31
left a comment
pvillard31
left a comment
There was a problem hiding this comment.
LGTM, left some minor comments
Comment on lines
39
to
40
| final FieldValue lhs = lhsPath.evaluate(context).findFirst().orElseThrow(); | ||
| final FieldValue rhs = rhsPath.evaluate(context).findFirst().orElseThrow(); |
Contributor
There was a problem hiding this comment.
Suggested change
| final FieldValue lhs = lhsPath.evaluate(context).findFirst().orElseThrow(); | |
| final FieldValue rhs = rhsPath.evaluate(context).findFirst().orElseThrow(); | |
| final FieldValue lhs = lhsPath.evaluate(context).findFirst() | |
| .orElseThrow(() -> new IllegalArgumentException("divide function requires a left-hand operand")); | |
| final FieldValue rhs = rhsPath.evaluate(context).findFirst() | |
| .orElseThrow(() -> new IllegalArgumentException("divide function requires a right-hand operand")); |
Comment on lines
39
to
40
| final FieldValue lhs = lhsPath.evaluate(context).findFirst().orElseThrow(); | ||
| final FieldValue rhs = rhsPath.evaluate(context).findFirst().orElseThrow(); |
Contributor
There was a problem hiding this comment.
Suggested change
| final FieldValue lhs = lhsPath.evaluate(context).findFirst().orElseThrow(); | |
| final FieldValue rhs = rhsPath.evaluate(context).findFirst().orElseThrow(); | |
| final FieldValue lhs = lhsPath.evaluate(context).findFirst() | |
| .orElseThrow(() -> new IllegalArgumentException("multiply function requires a left-hand operand")); | |
| final FieldValue rhs = rhsPath.evaluate(context).findFirst() | |
| .orElseThrow(() -> new IllegalArgumentException("multiply function requires a right-hand operand")); |
| entry("longNumber", 1234567890123456789L) | ||
| entry("shortNumber", (short) 123), | ||
| entry("longNumber", 1234567890123456789L), | ||
| entry("floatNumber", 123.45) |
Contributor
There was a problem hiding this comment.
Suggested change
| entry("floatNumber", 123.45) | |
| entry("floatNumber", 123.45f) |
| public class MathDivideOperator implements MathBinaryOperator { | ||
| @Override | ||
| public Long operate(Long n, Long m) { | ||
| return n / m; |
Contributor
There was a problem hiding this comment.
Suggested change
| return n / m; | |
| if (m == 0L) { | |
| throw new ArithmeticException("Division by zero in RecordPath divide function"); | |
| } | |
| return n / m; |
|
|
||
| @Override | ||
| public Double operate(Double n, Double m) { | ||
| return n / m; |
Contributor
There was a problem hiding this comment.
Suggested change
| return n / m; | |
| if (m == 0.0) { | |
| throw new ArithmeticException("Division by zero in RecordPath divide function"); | |
| } | |
| return n / m; |
r1b
force-pushed
the
feat/recordpath-ts-truncation
branch
2 times, most recently
from
5121695 to
74ce039
Compare
r1b
force-pushed
the
feat/recordpath-ts-truncation
branch
from
74ce039 to
52af40d
Compare
Contributor
Author
|
thanks @pvillard31 - I have applied the suggested changes with additional tests |
pvillard31
approved these changes
Jan 31, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15474
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation