NIFI-15920 improve accesibility around connector state text in listing#11225
Open
scottyaslan wants to merge 1 commit into
Open
NIFI-15920 improve accesibility around connector state text in listing#11225scottyaslan wants to merge 1 commit into
scottyaslan wants to merge 1 commit into
Conversation
Contributor
|
Reviewing... |
mcgilman
requested changes
May 11, 2026
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks for the PR @scottyaslan! Requesting changes due to failing tests but also looking for feedback on question below.
Comment on lines
-79
to
+82
| <span class="caution-color text-xs font-medium" data-qa="edits-not-applied-badge" | ||
| >(Edits not applied)</span | ||
| > | ||
| <i | ||
| class="neutral-color fa fa-asterisk" | ||
| matTooltip="Edits not applied" | ||
| matTooltipPosition="after"></i> |
Contributor
There was a problem hiding this comment.
Personally, I'm not a fan of this tooltip approach.
We already show EDITS NOT APPLIED in the Connector card in the Connector canvas. We probably need to align these. Assuming the Connector card also suffers with the yellow text on white surface maybe we can consider a little badge or something.
Thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15920
Current main has some unreadable text:
This PR utilized established pattern from nifi to mark the state of the connector as "edits not applied":
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation