NIFI-16098 Prevent content-claim truncation from dropping content referenced by a live sibling FlowFile#11414
Open
pvillard31 wants to merge 2 commits into
Open
NIFI-16098 Prevent content-claim truncation from dropping content referenced by a live sibling FlowFile#11414pvillard31 wants to merge 2 commits into
pvillard31 wants to merge 2 commits into
Conversation
…erenced by a live sibling FlowFile A FlowFile created and removed within a single session (e.g. ExecuteGroovyScript with Failure Strategy 'transfer to failure', which clones on get and removes the clone at commit) yields one repository record whose type transitions CREATE->DELETE. The truncation reference count is incremented only for a committed CREATE, so that increment never ran, but the DELETE still decremented it. For a content claim shared with a live sibling FlowFile this drove the truncation reference count to zero, allowing the claim to be truncated and the sibling's content to be lost. Only decrement the truncation reference count on delete of a persisted FlowFile (one that has an original claim).
…with an in-session cloned FlowFile Adds a CloneAndTerminate test processor that, for each incoming FlowFile, clones it and removes both the clone and the input within the same session (the record set produced by ExecuteGroovyScript with Failure Strategy 'transfer to failure'). A new ContentClaimTruncationIT case forks a generator to this processor and to a leg that holds the FlowFiles, and verifies the shared content claims are not truncated while the holding leg still references them. The test fails without the accompanying framework fix (content is truncated away) and passes with it.
Contributor
|
Thanks for fixing this so quickly, @pvillard31. I just built a copy of NiFi 2.10.0 incorporating your changes and it seems to be working correctly now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16098 Prevent content-claim truncation from dropping content referenced by a live sibling FlowFile
A FlowFile created and removed within a single session (e.g. ExecuteGroovyScript with Failure Strategy 'transfer to failure', which clones on get and removes the clone at commit) yields one repository record whose type transitions CREATE->DELETE. The truncation reference count is incremented only for a committed CREATE, so that increment never ran, but the DELETE still decremented it. For a content claim shared with a live sibling FlowFile this drove the truncation reference count to zero, allowing the claim to be truncated and the sibling's content to be lost.
Only decrement the truncation reference count on delete of a persisted FlowFile (one that has an original claim).
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation