NIFI-16104 Fix flaky ConnectorAssetsIT by polling for asset removal#11420
Open
pvillard31 wants to merge 1 commit into
Open
NIFI-16104 Fix flaky ConnectorAssetsIT by polling for asset removal#11420pvillard31 wants to merge 1 commit into
pvillard31 wants to merge 1 commit into
Conversation
pvillard31
force-pushed
the
fix/connector-assets-flaky-test
branch
from
July 11, 2026 06:49
608696d to
005a8c6
Compare
pvillard31
force-pushed
the
fix/connector-assets-flaky-test
branch
from
July 11, 2026 07:20
005a8c6 to
7a01224
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnectorAssetsIT.testCreateConnectorAndUploadAssetintermittently fails with:The test asserts that an unreferenced asset is removed immediately after
waitForConnectorState(STOPPED). Asset cleanup is asynchronous and may not have completed by the time the connector reaches STOPPED state, making the single-shot assertion inherently racy.Changes
NiFiClientUtil— addwaitForAssetRemoved(connectorId, assetId)utility that polls every 100 ms (matching thewaitForConnectorStatepattern) until the specified asset is absent from the connector's asset list.ConnectorAssetsIT— replace the immediate one-shotgetAssets/assertFalsecheck with a call towaitForAssetRemoved, tolerating the async cleanup delay.Tracking
Issue Tracking
Pull Request Tracking
NIFI-16084NIFI-16084Testing
testCreateConnectorAndUploadAssetnow reliably passes because it waits for the async asset cleanup instead of checking exactly once.