-
Notifications
You must be signed in to change notification settings - Fork 654
ping: add -I for bind device #3263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@simbit18 Why does this error only occur in MSVC? |
|
@acassis @wangchen61698 This error is also present. |
linguini1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide information on what "self-testing" includes on sim, and if possible any logs from the test that show that the issue you're solving is fixed with this change and was broken before the change.
Add -I option to specify the network device to use for sending ICMP echo requests. This allows users to explicitly bind ping to a specific network interface, which is particularly useful in multi-homed systems with multiple network interfaces. Signed-off-by: meijian <meijian@xiaomi.com>
Initialize info.devname to NULL to solve the problem of the SO-BINDTODEVICE property being set incorrectly in the icmp_ping function Signed-off-by: wangchen <wangchen41@xiaomi.com>
The test log has been supplemented. Please refer to the TESTING entry @linguini1 |
|
@wangchen61698 please update the https://nuttx.apache.org/docs/latest/applications/system/ping/index.html (create a basic documentation listing the options as you show here in the Summary). |
acassis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Documentation
Note: Please adhere to Contributing Guidelines.
Summary
Impact
ping
Testing
Please verify this PR together with another PR
apache/nuttx#17662
After the patch


Before the patch