net/wireless: fix compile warning issue for wireless #3269
+39
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HedongGao
changed the title
xiaoxiang781216
approved these changes
Dec 24, 2025
fix tasking compile warning isssue warnning log: unused variable "IEEE802154_STATUS_STRING" Signed-off-by: gaohedong <gaohedong@xiaomi.com>
dup g_ieee802154_status_string from kernel to fix cmopil issue Signed-off-by: gaohedong <gaohedong@xiaomi.com>
fix tasking compile warning isssue warnning log: undefined reference to 'g_ieee802154_status_string' Signed-off-by: gaohedong <gaohedong@xiaomi.com>
Contributor
|
It might be better to put this change in the same PR as before? That way there are no CI errors? |
Contributor
it's impossible since another change is inside nuttx repo. @linguini1 |
Contributor
My bad! Missed seeing that. |
linguini1
approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
IEEE802154_STATUS_STRING is defined in the .h file, which will generate compilation warning information under some compilers. Moved the position of the variable to fix this issue. At the same time, changed the name of the variable to unify the code style.
Impact
Rename static const char *IEEE802154_STATUS_STRING[] to FAR const char *g_ieee802154_status_string[]. Will not affect the functionality.
This PR needs to be merged with another PR
Testing
gcc compiler has no warning infor for nuttx-apps/wireless/ieee802154/i8sak, but tasking compiler has warning information.
warnning log: unused variable "IEEE802154_STATUS_STRING"
After the issue is fixed, the warning dispeared, and the results compiled with both compilers are normal.