Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 4, 2026

What changes were proposed in this pull request?

This PR aims to use Java 9+ Set.of() API instead of Collections.emptySet() and add a new checkstyle rule to ban Collections.emptySet.

Why are the changes needed?

We had better use Set simply and uniformly.

- import java.util.Collections;
...
- private Set<Integer> filterColumnIds = Collections.emptySet();
+ private Set<Integer> filterColumnIds = Set.of();

Does this PR introduce any user-facing change?

No behavior change.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the JAVA label Jan 4, 2026
@dongjoon-hyun
Copy link
Member Author

Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the ORC-2053 branch January 4, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant