HDDS-14425. Implement Ratis follower read exception handling#9811
Merged
ivandika3 merged 7 commits intoapache:masterfrom Mar 2, 2026
Merged
HDDS-14425. Implement Ratis follower read exception handling#9811ivandika3 merged 7 commits intoapache:masterfrom
ivandika3 merged 7 commits intoapache:masterfrom
Conversation
szetszwo
reviewed
Feb 27, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@ivandika3 , thanks for working on this!
- Could we just use the ReadException and ReadIndexException from Ratis instead of adding OmXxxException?
- Please resolve the merge conflict.
# Conflicts: # hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/HadoopRpcOMFollowerReadFailoverProxyProvider.java
szetszwo
approved these changes
Mar 1, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
|
@szetszwo Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It might be possible for Ratis to throw ReadIndexException if the follower is not able to get the ReadIndex one way or another (e.g. majority OMs are down). Additionally ReadException will be thrown for any pending requests. However, currently this is not handled by both the OM server and client.
OM need to throw these exceptions to prevent NPE similar to HDDS-10918. Client can parse these exceptions and log it.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14425
How was this patch tested?
Unit test.
Clean CI: https://github.com/ivandika3/ozone/actions/runs/22333622434