HDDS-14684. Allow deletion of empty quasi-closed containers#9856
Open
sarvekshayr wants to merge 1 commit intoapache:masterfrom
Open
HDDS-14684. Allow deletion of empty quasi-closed containers#9856sarvekshayr wants to merge 1 commit intoapache:masterfrom
sarvekshayr wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We now support tracking a container again if a new replica shows up with a higher BCSID after all replicas were deleted HDDS-14684. With this change, we delete empty quasi-closed containers from the system. Even if they were missing some blocks and a new replica shows up with those blocks, it would be tracked and replicated again.
Added empty QUASI_CLOSED container check and deletion in
EmptyContainerHandler.What is the link to the Apache JIRA
HDDS-14684
How was this patch tested?
Added integration test in
TestReplicationManagerIntegration#testEmptyQuasiClosedContainerDeletion.Existing test
TestContainerReportHandling#testDeletingOrDeletedContainerWhenNonEmptyReplicaIsReportedalready verifies the logic if non empty replica is reported.