#38 Expose More Metadata in Object APIs #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzelin
reviewed
Feb 19, 2025
| def new_predicate_builder(self) -> 'PredicateBuilder': | ||
| return PredicateBuilder(self._j_row_type) | ||
|
|
||
| def read_type(self) -> 'RowType': |
Contributor
There was a problem hiding this comment.
Maybe we can return pa.schema directly?
Contributor
Author
There was a problem hiding this comment.
For API's extensibility, peasonally I think this is better.
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #38
Expose More Metadata in Object APIs to Benefit External Read/Write Optimizations
Tests
API and Format
Yes.
RowTypewith methodas_arrow.row_count,file_size,file_pathsto the objectSplit.read_typeto the objectReadBuilder, which following the design of java paimon.Documentation