[flink] Add default parallelism for source and sink in rescale procedure, also make them configurable #5193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Mar 3, 2025
docs/content/flink/procedures.md
Outdated
| <td>rescale</td> | ||
| <td> | ||
| CALL [catalog.]sys.rescale(`table` => 'identifier', `bucket_num` => bucket_num, `partition` => 'partition') | ||
| CALL [catalog.]sys.rescale(`table` => 'identifier', `bucket_num` => bucket_num, `partition` => 'partition', `source_parallelism` => 'source_parallelism', `sink_parallelism` => 'sink_parallelism') |
Contributor
There was a problem hiding this comment.
scan.parallelism and sink.parallelism.
Just be consistent with Flink Connector options.
Contributor
Author
There was a problem hiding this comment.
No need. This is a procedure argument, not an option.
Contributor
There was a problem hiding this comment.
Can we maintain consistency, why not?
JingsongLi
reviewed
Mar 3, 2025
docs/content/flink/procedures.md
Outdated
| <li>bucket_num: Resulting bucket number after rescale. The default value of argument bucket_num is the current bucket number of the table. Cannot be empty for postpone bucket tables.</li> | ||
| <li>partition: What partition to rescale. For partitioned table this argument cannot be empty.</li> | ||
| <li>source_parallelism: Parallelism of source operator. The default value is the current bucket number of the partition.</li> | ||
| <li>partition: Parallelism of sink operator. The default value is equal to bucket_num.</li> |
…ure, also make them configurable
Contributor
|
+1 |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently user has no way to configure source and sink parallelism in rescale procedure. This PR adds default parallelism and make it configurable.
Tests
Existing tests should cover this change.
API and Format
No format changes.
Documentation
Document is also added.