refactor: remove deprecated DurableStateUpdateStore.deleteObject(persistenceId) (since Akka 2.6.20)#3290
Draft
He-Pin wants to merge 1 commit into
Draft
refactor: remove deprecated DurableStateUpdateStore.deleteObject(persistenceId) (since Akka 2.6.20)#3290He-Pin wants to merge 1 commit into
He-Pin wants to merge 1 commit into
Conversation
He-Pin
force-pushed
the
remove/deprecated-deleteObject
branch
2 times, most recently
from
582cfa2 to
d711969
Compare
Member
Author
|
Maybe we should keep this a little longer |
He-Pin
force-pushed
the
remove/deprecated-deleteObject
branch
from
d711969 to
569ba6e
Compare
…istenceId) (since Akka 2.6.20) Motivation: The single-argument deleteObject(persistenceId) was deprecated since Akka 2.6.20 in favor of the overload that takes a revision parameter for optimistic locking. Modification: Remove the deprecated abstract method from both scaladsl and javadsl DurableStateUpdateStore traits. Remove the corresponding TCK test. Result: Only the revision-aware deleteObject(persistenceId, revision) remains. Implementation projects (r2dbc, jdbc, cassandra, dynamodb) will need to remove their overrides of the deleted method. Tests: Not run - trait method removal with TCK test cleanup References: None - deprecated API cleanup
He-Pin
force-pushed
the
remove/deprecated-deleteObject
branch
from
569ba6e to
c87fdcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The single-argument
deleteObject(persistenceId)was deprecated since Akka 2.6.20 in favor of the overload that takes arevisionparameter for optimistic locking.Modification
Remove the deprecated abstract method from both scaladsl and javadsl
DurableStateUpdateStoretraits. Remove the corresponding TCK test for the deprecated overload.Result
Only the revision-aware
deleteObject(persistenceId, revision)remains in the trait.Note: Implementation projects (pekko-persistence-r2dbc, pekko-persistence-jdbc, pekko-persistence-cassandra, pekko-persistence-dynamodb) will need follow-up PRs to remove their overrides of this deleted method.
Tests
Not run - trait method removal with TCK test cleanup
References
None - deprecated API cleanup