RATIS-2191. Add ResourceLeakDetector to Netty tests #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
approved these changes
Nov 22, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
szetszwo
pushed a commit
that referenced
this pull request
Jan 9, 2025
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
May 23, 2025
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Similar to LeakDetector#assertNoLeaks in MiniRaftCluster, we can also add the Netty leak detector in tests as specified in https://netty.io/wiki/reference-counted-objects.html#wiki-h2-9 to ensure that all ByteBuf are released.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2191
How was this patch tested?
Intentionally add leak add check that
IllegalStateExceptionis thrown: https://github.com/ivandika3/ratis/actions/runs/11871018319/job/33121223662