Skip to content

RATIS-2244. Reduce the number of log messages during bootstrap #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
venkatsambath wants to merge 1 commit into from
Closed

RATIS-2244. Reduce the number of log messages during bootstrap #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ private void onNextImpl(AppendEntriesRequest request, AppendEntriesReplyProto re
break;
case INCONSISTENCY:
grpcServerMetrics.onRequestInconsistency(getFollowerId().toString());
LOG.warn("{}: received {} reply with nextIndex {}, errorCount={}, request={}",
LOG.debug("{}: received {} reply with nextIndex {}, errorCount={}, request={}",
this, reply.getResult(), reply.getNextIndex(), errorCount, request);
final long requestFirstIndex = request != null? request.getFirstIndex(): RaftLog.INVALID_LOG_INDEX;
updateNextIndex(getNextIndexForInconsistency(requestFirstIndex, reply.getNextIndex()));
Expand Down
4 changes: 2 additions & 2 deletions ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcServerProtocolService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,9 @@ public void onNext(REQUEST request) {
@Override
public void onCompleted() {
if (isClosed.compareAndSet(false, true)) {
LOG.info("{}: Completed {}, lastRequest: {}", getId(), op, getPreviousRequestString());
LOG.debug("{}: Completed {}, lastRequest: {}", getId(), op, getPreviousRequestString());
requestFuture.get().thenAccept(reply -> {
LOG.info("{}: Completed {}, lastReply: {}", getId(), op, reply);
LOG.debug("{}: Completed {}, lastReply: {}", getId(), op, reply);
responseObserver.onCompleted();
});
releaseLast();
Expand Down
8 changes: 4 additions & 4 deletions ratis-server/src/main/java/org/apache/ratis/server/impl/SnapshotInstallationHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ long getInProgressInstallSnapshotIndex() {
}

InstallSnapshotReplyProto installSnapshot(InstallSnapshotRequestProto request) throws IOException {
if (LOG.isInfoEnabled()) {
LOG.info("{}: receive installSnapshot: {}", getMemberId(),
if (LOG.isDebugEnabled()) {
LOG.debug("{}: receive installSnapshot: {}", getMemberId(),
ServerStringUtils.toInstallSnapshotRequestString(request));
}
final InstallSnapshotReplyProto reply;
Expand All @@ -104,8 +104,8 @@ InstallSnapshotReplyProto installSnapshot(InstallSnapshotRequestProto request) t
LOG.error("{}: installSnapshot failed", getMemberId(), e);
throw e;
}
if (LOG.isInfoEnabled()) {
LOG.info("{}: reply installSnapshot: {}", getMemberId(),
if (LOG.isDebugEnabled()) {
LOG.debug("{}: reply installSnapshot: {}", getMemberId(),
ServerStringUtils.toInstallSnapshotReplyString(reply));
}
return reply;
Expand Down