Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Ratis defines some repositories unnecessarily.

  1. Ratis does not use any snapshot dependencies. Even if it did, we could use repo definition from Apache parent POM.
  2. Central repo contains all dependencies, JBoss repo is not needed.

https://issues.apache.org/jira/browse/RATIS-2358

How was this patch tested?

Full CI:
https://github.com/adoroszlai/ratis/actions/runs/19325584112

Before, build unsuccessfully tried to download few Apache dependencies from repository.jboss.org. All other dependencies were fetched from Central without attempt from JBoss.

[INFO] Downloading from repository.jboss.org: https://repository.jboss.org/nexus/content/groups/public/org/apache/apache/35/apache-35.pom
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/apache/35/apache-35.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/apache/35/apache-35.pom (24 kB at 276 kB/s)
...
[INFO] Downloading from repository.jboss.org: https://repository.jboss.org/nexus/content/groups/public/org/apache/apache/resources/apache-jar-resource-bundle/1.7/apache-jar-resource-bundle-1.7.jar
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/apache/resources/apache-jar-resource-bundle/1.7/apache-jar-resource-bundle-1.7.jar
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/apache/resources/apache-jar-resource-bundle/1.7/apache-jar-resource-bundle-1.7.jar (13 kB at 391 kB/s)
...
[INFO] Downloading from repository.jboss.org: https://repository.jboss.org/nexus/content/groups/public/org/apache/ratis/ratis-thirdparty-misc/1.0.10/ratis-thirdparty-misc-1.0.10.pom
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-thirdparty-misc/1.0.10/ratis-thirdparty-misc-1.0.10.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-thirdparty-misc/1.0.10/ratis-thirdparty-misc-1.0.10.pom (13 kB at 405 kB/s)
[INFO] Downloading from repository.jboss.org: https://repository.jboss.org/nexus/content/groups/public/org/apache/ratis/ratis-thirdparty/1.0.10/ratis-thirdparty-1.0.10.pom
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-thirdparty/1.0.10/ratis-thirdparty-1.0.10.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-thirdparty/1.0.10/ratis-thirdparty-1.0.10.pom (17 kB at 362 kB/s)
[INFO] Downloading from repository.jboss.org: https://repository.jboss.org/nexus/content/groups/public/org/apache/ratis/ratis-thirdparty-misc/1.0.10/ratis-thirdparty-misc-1.0.10.jar
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-thirdparty-misc/1.0.10/ratis-thirdparty-misc-1.0.10.jar
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-thirdparty-misc/1.0.10/ratis-thirdparty-misc-1.0.10.jar (19 MB at 66 MB/s)

After, no such attempts:

[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/apache/35/apache-35.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/apache/35/apache-35.pom (24 kB at 43 kB/s)
...
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/apache/resources/apache-jar-resource-bundle/1.7/apache-jar-resource-bundle-1.7.jar
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/apache/resources/apache-jar-resource-bundle/1.7/apache-jar-resource-bundle-1.7.jar (13 kB at 537 kB/s)
...
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-thirdparty-misc/1.0.10/ratis-thirdparty-misc-1.0.10.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-thirdparty-misc/1.0.10/ratis-thirdparty-misc-1.0.10.pom (13 kB at 483 kB/s)
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-thirdparty/1.0.10/ratis-thirdparty-1.0.10.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-thirdparty/1.0.10/ratis-thirdparty-1.0.10.pom (17 kB at 567 kB/s)
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-thirdparty-misc/1.0.10/ratis-thirdparty-misc-1.0.10.jar
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-thirdparty-misc/1.0.10/ratis-thirdparty-misc-1.0.10.jar (19 MB at 62 MB/s)

@adoroszlai adoroszlai self-assigned this Nov 13, 2025
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Awesome work!

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@adoroszlai adoroszlai merged commit 1b64422 into apache:master Nov 13, 2025
15 checks passed
@adoroszlai adoroszlai deleted the RATIS-2358 branch November 13, 2025 18:25
@adoroszlai
Copy link
Contributor Author

Thanks @OneSizeFitsQuorum, @szetszwo for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants