-
Notifications
You must be signed in to change notification settings - Fork 38
chore(docs): Add a validation script for SQL reference #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
yutannihilation
wants to merge
8
commits into
apache:main
Choose a base branch
from
yutannihilation:doc/validate-script
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3eafa69
Add a script
yutannihilation 8bbc457
Fix a typo
yutannihilation 17c5724
Improve
yutannihilation 2ba264e
Update docs/scripts/validate_sql.py
yutannihilation 94f0b23
Merge branch 'main' into doc/validate-script
yutannihilation 44dd90d
Include `rs_` function
yutannihilation 765eb37
Improve SQL
yutannihilation d145584
Merge branch 'doc/validate-script' of https://github.com/yutannihilat…
yutannihilation File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| import sedonadb | ||
| import difflib | ||
| from pathlib import Path | ||
|
|
||
| HERE = Path(__file__).parent | ||
|
|
||
| with open(HERE.parent / "reference" / "sql.md", "r") as f: | ||
| lines = f.readlines() | ||
| # Headers with `##` are the function names. | ||
| funs_in_doc = [line[3:-1] for line in lines if line.startswith("## ")] | ||
|
|
||
|
|
||
| ### Check if all the functions are documented | ||
|
|
||
| sd = sedonadb.connect() | ||
| df = sd.sql(r""" | ||
| SELECT DISTINCT | ||
| routine_name, | ||
| function_type, | ||
| CASE substr(routine_name, 1, 2) | ||
| WHEN 'st' THEN 'vector' | ||
| WHEN 'rs' THEN 'raster' | ||
| ELSE 'unknown' | ||
| END AS data_type, | ||
| count(*) OVER (PARTITION BY description) > 1 as has_alias | ||
| FROM information_schema.routines | ||
| WHERE routine_type = 'FUNCTION' AND regexp_like(routine_name, '^(st_|rs_)') | ||
| ORDER BY routine_name | ||
| """).to_pandas() | ||
| funs_in_impl_set = set(df["routine_name"].tolist()) | ||
|
|
||
| funs_in_doc_set = set(f.lower() for f in funs_in_doc) | ||
|
|
||
| funs_only_in_impl = sorted(funs_in_impl_set - funs_in_doc_set) | ||
| funs_only_in_doc = sorted(funs_in_doc_set - funs_in_impl_set) | ||
|
|
||
| if funs_only_in_impl or funs_only_in_doc: | ||
| print("\nFunctions only in implementation:\n - ", end="") | ||
| print("\n - ".join(funs_only_in_impl)) | ||
| print("\nFunctions only in document:\n - ", end="") | ||
| print("\n - ".join(funs_only_in_doc)) | ||
| print("\n") | ||
|
|
||
| raise RuntimeError( | ||
| "There are some mismatch between the SQL reference and the actual implementation!" | ||
| ) | ||
|
|
||
|
|
||
| ### Check if the function order is sorted | ||
|
|
||
| if funs_in_doc != sorted(funs_in_doc): | ||
| diff = difflib.unified_diff( | ||
| funs_in_doc, sorted(funs_in_doc), fromfile="current", tofile="sorted" | ||
| ) | ||
|
|
||
| print("\n".join(diff)) | ||
|
|
||
| raise RuntimeError("The SQL functions are not sorted in alphabetical order") | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the information about aliases cannot be retrieved by SQL. I added a tweak to guess it from
description, but I'm not sure if this is reliable enough.I might rewrite the validation script by using Rust just like DataFusion does to generate the documentation.
https://github.com/apache/datafusion/blob/5a01e68643a198a1aaa7124524d7be5be7df24ec/datafusion/core/src/bin/print_functions_docs.rs#L174-L179