SLING-12376 : Use per thread resource resolver for disposable callbacks#56
Open
SLING-12376 : Use per thread resource resolver for disposable callbacks#56
Conversation
Member
|
what happens if sling models is used outside a request context, e.g. in a background job with a resource resolver created via |
Contributor
Author
|
Then this code blows up with a NullPointerException...the same is true when using an administrative resource resolver |
Member
|
it's a valid use case, although probably rare, to use sling models outside a request... |
Contributor
Author
|
not disagreeing, lets see if we can come up with something that is better than the previous solution |
|
1 similar comment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Instead of using different approaches (request attribute and phantom reference queue), we can use the thread resource resolver and store the disposables in the properties map of the resource resolver. When the resource resolver is closed, it closes all Closeable objects in the properties map
With that we can remove the different cases, queue handling, and scheduling.
In addition I removed the anti pattern of registering services during activate