SLING-13088: [Sling Models] Migrate ModelAdapterFactory, Ordering & OSGi tests to JUnit 5#80
Merged
stefanseifert merged 1 commit intoapache:masterfrom Feb 9, 2026
Conversation
…d OSGi tests to JUnit 5
ea6dda5 to
87956e1
Compare
stefanseifert
requested changes
Feb 9, 2026
Member
stefanseifert
left a comment
There was a problem hiding this comment.
great - thanks again for this PR for the migration.
please see my note regarding the IT fix, it should not be part of this PR, and is likely not fixing the root cause for the flakyness we have from time to time.
87956e1 to
e48025d
Compare
|
stefanseifert
approved these changes
Feb 9, 2026
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue: SLING-13088
ModelAdapterFactoryTestModelAdapterFactory_ImplementationPickerOrderTestModelAdapterFactory_InjectorOrderTestModelPackageBundleListenerTestMultipleInjectorTestOSGiInjectionTestOptionalObjectsTestOptionalPrimitivesTestMockitoJUnitRunnerwith@ExtendWith(MockitoExtension.class)@Test(expected)toassertThrows()doReturn().when()to resolve generic type inference issues<?>wildcards to rawTypevariables to fix compiler warningslogvariables tologgerto avoid conflictseq()matchers and redundantthrowsdeclarations@SuppressWarningsand resolved related Sonar issueslenient()strictness to preserve legacy behavior