Ensure initContainer sets SOLR_TOOL_OPTS based on SOLR_OPTS value #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Still need a changelog entry here, and a bit of cleanup for other env-vars we were setting that are unused. (i.e. things that were utilized by zkcli.sh previously) |
gerlowskija
deleted the
set_solrtoolopts_appropriately_for_init_container
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #717 by ensuring that all SOLR_OPTS values (which include all ZK connection settings) are also set in the SOLR_TOOL_OPTS variable utilized by
bin/solr zk