Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

public class DateUtils {
private static final DateTimeFormatter DATE_FORMATTER = DateTimeFormatter.ofPattern("yyyy-MM-dd");
public static final int EMPTY_DATE_INT = 10000101;

public static String formatDate(int date) {
return date / 10000
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public int write(long time, List<DataPoint> data) throws WriteProcessException,
break;
case INT32:
case DATE:
valueChunkWriter.write(time, (int) point.getValue(), isNull);
valueChunkWriter.write(time, isNull ? 0 : (int) point.getValue(), isNull);
break;
case INT64:
case TIMESTAMP:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,11 @@ private void serializeColumn(
case DATE:
LocalDate[] dateValues = (LocalDate[]) column;
for (int j = 0; j < rowSize; j++) {
ReadWriteIOUtils.write(DateUtils.parseDateExpressionToInt(dateValues[j]), stream);
ReadWriteIOUtils.write(
dateValues[j] == null
? DateUtils.EMPTY_DATE_INT
: DateUtils.parseDateExpressionToInt(dateValues[j]),
stream);
}
break;
case INT64:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public void writeTo(long time, ChunkWriterImpl writer) throws IOException {

@Override
public Object getValue() {
return DateUtils.parseDateExpressionToInt(value);
return value == null ? null : DateUtils.parseDateExpressionToInt(value);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@
import org.apache.tsfile.write.chunk.ChunkWriterImpl;
import org.apache.tsfile.write.record.TSRecord;
import org.apache.tsfile.write.record.Tablet;
import org.apache.tsfile.write.record.datapoint.DateDataPoint;
import org.apache.tsfile.write.record.datapoint.StringDataPoint;
import org.apache.tsfile.write.schema.IMeasurementSchema;
import org.apache.tsfile.write.schema.MeasurementSchema;
import org.apache.tsfile.write.writer.TsFileIOWriter;
Expand Down Expand Up @@ -549,6 +551,31 @@ public void writeAlignedWithTabletWithNullValue() {
}
}

@Test
public void writeRecordWithNullValue() {
setEnv(100, 30);
measurementSchemas.add(new MeasurementSchema("s1", TSDataType.TEXT, TSEncoding.PLAIN));
measurementSchemas.add(new MeasurementSchema("s2", TSDataType.STRING, TSEncoding.PLAIN));
measurementSchemas.add(new MeasurementSchema("s3", TSDataType.BLOB, TSEncoding.PLAIN));
measurementSchemas.add(new MeasurementSchema("s4", TSDataType.DATE, TSEncoding.PLAIN));
try (TsFileWriter tsFileWriter = new TsFileWriter(f)) {

// register aligned timeseries
tsFileWriter.registerAlignedTimeseries(new Path(deviceId), measurementSchemas);

TSRecord record = new TSRecord(deviceId, 0);
record.addTuple(new StringDataPoint("s1", null));
record.addTuple(new StringDataPoint("s2", null));
record.addTuple(new StringDataPoint("s3", null));
record.addTuple(new DateDataPoint("s4", null));

tsFileWriter.writeRecord(record);
} catch (Throwable e) {
e.printStackTrace();
Assert.fail("Meet errors in test: " + e.getMessage());
}
}

@Test
public void writeDataToTabletsWithNegativeTimestamps() {
setEnv(100, 30);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import org.junit.Assert;
import org.junit.Test;

import java.io.IOException;
import java.nio.ByteBuffer;
import java.time.LocalDate;
import java.util.ArrayList;
Expand Down Expand Up @@ -278,4 +279,22 @@ private void addValueWithException(Tablet tablet, String column, int rowIndex, O
}
Assert.fail();
}

@Test
public void testSerializeDateColumnWithNullValue() throws IOException {
final List<IMeasurementSchema> measurementSchemas = new ArrayList<>();
measurementSchemas.add(new MeasurementSchema("s1", TSDataType.DATE, TSEncoding.PLAIN));
measurementSchemas.add(new MeasurementSchema("s2", TSDataType.DATE, TSEncoding.PLAIN));
Tablet tablet = new Tablet("root.testsg.d1", measurementSchemas);
tablet.addTimestamp(0, 0);
tablet.addValue(0, 0, LocalDate.now());
tablet.addTimestamp(1, 1);
tablet.addValue(1, 1, LocalDate.now());
ByteBuffer serialized = tablet.serialize();
Tablet deserializeTablet = Tablet.deserialize(serialized);
Assert.assertEquals(tablet.getValue(0, 0), deserializeTablet.getValue(0, 0));
Assert.assertTrue(deserializeTablet.isNull(0, 1));
Assert.assertEquals(tablet.getValue(1, 1), deserializeTablet.getValue(1, 1));
Assert.assertTrue(deserializeTablet.isNull(1, 0));
}
}
Loading