feat: Add tvm_ffi.Function.__init__ (Reintroduce #395) #407
Conversation
This reverts commit 91fcaa8.
Summary of ChangesHello @junrushao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reintroduces the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reintroduces the tvm_ffi.Function.__init__ method, allowing for more convenient creation of tvm_ffi.Function objects from Python callables. The changes span C++ header files for documentation updates, Python stub files for type hinting, the core Cython implementation, and a new test case. My review focuses on the Cython implementation, where I've identified a potential memory leak and suggested a fix to ensure resource safety.
| cdef TVMFFIObjectHandle chandle = NULL | ||
| if not callable(func): | ||
| raise TypeError(f"func must be callable, got {type(func)}") | ||
| if isinstance(func, Function): | ||
| chandle = (<Object>func).chandle | ||
| TVMFFIObjectIncRef(chandle) | ||
| else: | ||
| _convert_to_ffi_func_handle(func, &chandle) | ||
| self.chandle = chandle |
There was a problem hiding this comment.
Calling __init__ on an already-initialized tvm_ffi.Function object will cause a memory leak. The current implementation overwrites self.chandle without decrementing the reference count of the previously held handle. To prevent this and enforce that __init__ acts as a one-time constructor, you should add a check to ensure the object is not already initialized.
if self.chandle != NULL:
raise TypeError("A tvm_ffi.Function object can only be initialized once.")
cdef TVMFFIObjectHandle chandle = NULL
if not callable(func):
raise TypeError(f"func must be callable, got {type(func)}")
if isinstance(func, Function):
chandle = (<Object>func).chandle
TVMFFIObjectIncRef(chandle)
else:
_convert_to_ffi_func_handle(func, &chandle)
self.chandle = chandle
1 participant
Reverts #406
Once the downstream fix to get in, we can safely reintroduce this PR