Improve JdbcExecutor traversal by safely handling missing or multiple consumers#711
Open
mohit-devlogs wants to merge 1 commit intoapache:mainfrom
Open
Improve JdbcExecutor traversal by safely handling missing or multiple consumers#711mohit-devlogs wants to merge 1 commit intoapache:mainfrom
mohit-devlogs wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves the robustness of JdbcExecutor by relaxing the assumption that the retrieval of consumers from the output channel is a singleton.
In the previous code, the function findJdbcExecutionOperatorTaskInStage() in the class WayangJdbcExecutor used the function WayangCollections.getSingle() for the retrieval of consumers from the output channel. The function throws an IllegalArgumentException if the list of consumers is empty or if there are more than one consumers in the list.
Changes:
This prevents crashes like this:
IllegalArgumentException: [] is not a singleton
Testing:
mvn -pl wayang-platforms/wayang-generic-jdbc test