Improve robustness of JdbcExecutor by safely handling multiple consumers#712
Open
mohit-devlogs wants to merge 1 commit intoapache:mainfrom
Open
Improve robustness of JdbcExecutor by safely handling multiple consumers#712mohit-devlogs wants to merge 1 commit intoapache:mainfrom
mohit-devlogs wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the JdbcExecutor more robust by removing the faulty use of
WayangCollections.getSingle() in the function findJdbcExecutionOperatorTaskInStage().
The faulty function could potentially throw an exception if there were zero or
multiple consumers on the channel. This could cause the following runtime errors:
"[] is not a singleton"
This change will guarantee that the function now checks the number of consumers
before trying to access them, returning null if it doesn’t match the execution
pattern.
This is a status quo change, removing unneeded runtime errors in the JDBC
execution path.