WICKET-7170: AnnotProxyFieldValueFactory now considers defaultCandidate #1311
+166
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hosea
commented
Nov 26, 2025
...ring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java
Show resolved
Hide resolved
hosea
commented
Nov 26, 2025
...ring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java
Show resolved
Hide resolved
Contributor
Author
|
When merged, I will create a follow-up-PR that improves and refactores ony the tests. |
bitstorm
approved these changes
Nov 26, 2025
martin-g
approved these changes
Nov 27, 2025
...ring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java
Outdated
Show resolved
Hide resolved
...ring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java
Outdated
Show resolved
Hide resolved
...ring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java
Outdated
Show resolved
Hide resolved
...ring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java
Outdated
Show resolved
Hide resolved
...ring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java
Outdated
Show resolved
Hide resolved
...ring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java
Outdated
Show resolved
Hide resolved
...ring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java
Outdated
Show resolved
Hide resolved
...rg/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryDefaultCandidateTest.java
Outdated
Show resolved
Hide resolved
...rg/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryDefaultCandidateTest.java
Outdated
Show resolved
Hide resolved
…/annot/AnnotProxyFieldValueFactory.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
…/annot/AnnotProxyFieldValueFactory.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
…/annot/AnnotProxyFieldValueFactory.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
…/annot/AnnotProxyFieldValueFactory.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
…/annot/AnnotProxyFieldValueFactory.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
…/annot/AnnotProxyFieldValueFactory.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
…/annot/AnnotProxyFieldValueFactory.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
…/annot/AnnotProxyFieldValueFactoryDefaultCandidateTest.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
…/annot/AnnotProxyFieldValueFactoryDefaultCandidateTest.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
Contributor
Author
|
@martin-g : Thank you, applied all suggestions. I'm really used to "{" at the end of a line instead of a new line starting with "{" ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://issues.apache.org/jira/browse/WICKET-7170