Feature/wicket 7170 followup improve tests #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 28, 2025 00:29
…on for SpringBean-Annotation and Jakarta-Annotation
… both (SpringBean and JakartaInject) and additional Test-medhot 'optional'
hosea
commented
Nov 28, 2025
.../src/test/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryTest.java
Show resolved
Hide resolved
martin-g
reviewed
Dec 2, 2025
.../src/test/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryTest.java
Outdated
Show resolved
Hide resolved
…/annot/AnnotProxyFieldValueFactoryTest.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
…/annot/AnnotProxyFieldValueFactoryTest.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
…/annot/AnnotProxyFieldValueFactoryTest.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
…/annot/AnnotProxyFieldValueFactoryTest.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
…/annot/AnnotProxyFieldValueFactoryTest.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
Contributor
Author
|
@martin-g : Thank your for your review. |
bitstorm
approved these changes
Dec 3, 2025
martin-g
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up-PR addressing only the tests of AnnotProxyFieldValueFactory.
Tests were completly updated and rewritten during Wicket-7170 to ensure better test coverage.
The PR consists of several commits, that do a step by step migration: