fix: add podUpdatePolicy to all ComponentDefinition templates#2515
Open
Alegrowin wants to merge 1 commit intoapecloud:mainfrom
Open
fix: add podUpdatePolicy to all ComponentDefinition templates#2515Alegrowin wants to merge 1 commit intoapecloud:mainfrom
Alegrowin wants to merge 1 commit intoapecloud:mainfrom
Conversation
Contributor
|
It’s not necessary to explicitly set podUpdatePolicy in addon manifests after apecloud/kubeblocks#10095, because the actual compatibility issue is resolved by excluding these fields from cmpdHash(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
podUpdatePolicyis not explicitly set in cmpd templates, the KubeBlocks operator defaults it toPreferInPlaceafter creation. This changes theapps.kubeblocks.io/immutable-hashannotation, causing the addon controller to mark ComponentDefinitions as Unavailable with"immutable fields can't be updated"on next reconciliation.Changes
Adds
podUpdatePolicy: PreferInPlaceto all 122 ComponentDefinition template files across all addons, ensuring the hash is stable from creation.Affected addons: apecloud-mysql, clickhouse, elasticsearch, etcd, falkordb, greptimedb, influxdb, kafka, llm, loki, mariadb, milvus, minio, mogdb, mongodb, mysql, nebula, neo4j, neon, opensearch, orchestrator, orioledb, polardbx, postgresql, pulsar, qdrant, rabbitmq, redis, risingwave, rocketmq, starrocks-ce, tidb, vanilla-postgresql, victoria-metrics, weaviate, xinference, yashandb, zookeeper
Verification
helm upgrade -i kb-addon-rabbitmq kubeblocks-addons/rabbitmq -n kubeblocks-system)podUpdatePolicy: PreferInPlaceset:kubectl get cmpd <name> -o yaml | grep podUpdatePolicykubectl get cmpd <name> -o jsonpath='{.metadata.annotations.apps\.kubeblocks\.io/immutable-hash}'Companion PR
PodUpdatePolicy/PodUpgradePolicyincmpdHash()(root cause fix in the hash function itself)