[codex] Restrict SOQL FORMULA to WHERE

CHANGELOG.md

@@ -1,5 +1,9 @@
 # apex-parser - Changelog
 
+## Unreleased
+
+- Restrict SOQL `FORMULA()` expressions to `WHERE` clauses; `HAVING FORMULA(...)` now reports a syntax error.
+
 ## 5.1.0-beta.1
 
 - Allow functions in `GROUP BY` clause of SOQL queries

antlr/BaseApexParser.g4

@@ -693,7 +693,20 @@ usingScope
     : USING SCOPE soqlId;
 
 whereClause
-    : WHERE logicalExpression;
+    : WHERE whereLogicalExpression;
+
+whereLogicalExpression
+    : whereConditionalExpression (SOQLAND whereConditionalExpression)*
+    | whereConditionalExpression (SOQLOR whereConditionalExpression)*
+    | NOT whereConditionalExpression;
+
+whereConditionalExpression
+    : LPAREN whereLogicalExpression RPAREN
+    | whereFieldExpression;
+
+whereFieldExpression
+    : fieldExpression
+    | FORMULA LPAREN StringLiteral RPAREN comparisonOperator value;
 
 logicalExpression
     : conditionalExpression (SOQLAND conditionalExpression)*
@@ -706,8 +719,7 @@ conditionalExpression
 
 fieldExpression
     : fieldName comparisonOperator value
-    | soqlFunction comparisonOperator value
-    | FORMULA LPAREN StringLiteral RPAREN comparisonOperator value;
+    | soqlFunction comparisonOperator value;
 
 comparisonOperator
     : ASSIGN | NOTEQUAL | LT | GT | LT ASSIGN | GT ASSIGN | LESSANDGREATER | LIKE | IN | NOT IN | INCLUDES | EXCLUDES;

jvm/src/test/java/io/github/apexdevtools/apexparser/SOQLParserTest.java

@@ -250,4 +250,14 @@ void testFormulaFunctionWithEscapedQuotes() {
     assertNotNull(context);
     assertEquals(0, parserAndCounter.getValue().getNumErrors());
   }
+
+  @Test
+  void testFormulaFunctionNotAllowedInHaving() {
+    Map.Entry<ApexParser, SyntaxErrorCounter> parserAndCounter = createParser(
+      "SELECT Name FROM Account GROUP BY Name HAVING FORMULA('1+1') = 2"
+    );
+    ApexParser.QueryContext context = parserAndCounter.getKey().query();
+    assertNotNull(context);
+    assertTrue(parserAndCounter.getValue().getNumErrors() > 0);
+  }
 }

npm/test/SOQLParserTest.ts

@@ -244,3 +244,14 @@ test("testFormulaFunctionWithEscapedQuotes", () => {
   expect(context).toBeInstanceOf(QueryContext);
   expect(errorCounter.getNumErrors()).toEqual(0);
 });
+
+test("testFormulaFunctionNotAllowedInHaving", () => {
+  const [parser, errorCounter] = createParser(
+    "SELECT Name FROM Account GROUP BY Name HAVING FORMULA('1+1') = 2"
+  );
+
+  const context = parser.query();
+
+  expect(context).toBeInstanceOf(QueryContext);
+  expect(errorCounter.getNumErrors()).toBeGreaterThan(0);
+});