Reduce disabled ESLint rules#87
Merged
kjonescertinia merged 1 commit intoJul 9, 2026
Merged
Conversation
kjonescertinia
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #72.
This reduces the ESLint disabled-rule list by re-enabling four focused rules:
@typescript-eslint/only-throw-error@typescript-eslint/no-require-importsno-useless-assignmentpreserve-caught-errorThe related code changes replace a thrown plain object with
Error, remove useless temporary assignments, and preserve caught errors ascausewithout requiring a newer TypeScriptErrorconstructor overload.The one remaining
require('*.apex')call now has a targeted inline exception because the repo's TS transformer specifically inlines Apex source fromrequire()calls. The broader config disable is no longer needed.The remaining disabled-rule groups now have short rationale comments in
eslint.config.js, so future cleanup work has clearer boundaries.Verification
npm run lintnpm run buildnpm testpassed with elevated filesystem access for Salesforce CLI logs under~/.sfnpm run lintstill reports the pre-existing six@typescript-eslint/no-unused-varswarnings, but no errors.