Merge apex-types repository into outline-parser#23
Merged
Conversation
This commit merges the apex-types library (v1.3.0) into outline-parser to simplify the dependency chain and enable future improvements to diagnostic position reporting. Changes: - Added all apex-types source files (18 Scala, 4 Java, 3 JS-specific) - com.financialforce.types.* (type interfaces) - com.financialforce.types.base.* (base types like Modifier, Annotation, Location) - io.github.apexdevtools.api.* (Issue API for JVM/JS) - io.github.apexdevtools.spi.* (AnalysisProvider SPI for JVM) - Removed apex-types dependency from build.sbt - Updated project description to reflect bundled type definitions - Updated README.md to document the merge All 6,302 existing tests pass successfully. This is a foundation for addressing diagnostic position issues reported in apex-dev-tools/apex-ls#434. Resolves #18
- Update Java 8 -> 17 - Update Node 16 -> 22 - Add sbt/setup-sbt@v1 to install sbt - Update checkout action v3 -> v4 This aligns with apex-ls and uses currently supported versions.
- Update Java 8 -> 17 - Update Node 16 -> 22 - Update apex-samples v1.0.2 -> v1.4.0 - Add sbt/setup-sbt@v1 to install sbt - Update checkout action v3 -> v4 This aligns with apex-ls and uses currently supported versions. All 6,302 tests pass with these updates.
kjonescertinia
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR merges the apex-types repository (v1.3.0) into outline-parser to simplify the dependency chain and enable future improvements to diagnostic position reporting.
Changes
Added Files (25 total)
com.financialforce.typesITypeDeclaration,IMethodDeclaration,IFieldDeclaration,IConstructorDeclaration, etc.Modifier,Annotation,Location,TypeRef,QualifiedName, etc.io.github.apexdevtools.api)io.github.apexdevtools.api+io.github.apexdevtools.spi)Modified Files
apex-typesdependencyTesting
✅ All 6,302 existing tests pass successfully
Benefits
ModifierandAnnotationwithout cross-repo coordinationMigration Path for Consumers
Before (outline-parser 1.x):
After (outline-parser 2.0.0):
Import paths remain unchanged (
com.financialforce.types.*), so no code changes needed in consumers.Next Steps
After this is merged:
Related Issues
Closes #18
Related to apex-dev-tools/apex-ls#434