Prepare 2.0.0-beta.1: bump apex-parser to 5, drop apex-ls test dep#29
Merged
Conversation
Breaks the outline-parser <-> apex-ls test-time cycle so apex-ls can adopt upstream. The JVM comparison test suite (SampleTest, AntlrParser, ClassScanner) now uses apex-parser 5's ApexParserFactory directly instead of the apex-ls CodeParser/PathLike shims. JS-side sample comparison is dropped; the JS test suite is reduced to SmokeTest. - Drop apex-ls 6.0.2 test dependency from build.sbt - Add apex-parser 5.0.0 + scala-parallel-collections as JVM Test deps - Move SampleTest, AntlrParser, ClassScanner from shared/ to jvm/ - Rewrite AntlrParser to call ApexParserFactory.createLexer/createParser with an inline CollectingErrorListener - Replace PathLike with java.nio.file.Path throughout test infrastructure - Delete js AntlrOps (no JS tests need it after refactor) - Bump npm @apexdevtools/apex-parser peer to ^5.0.0 - Draft CHANGELOG for 2.0.0-beta.1 scalafmtCheckAll clean; 6314 JVM tests + 52 JS tests pass.
Contributor
Author
|
@claude review |
nawforce
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apex-parser 5.x(ApexParserFactory) directly instead of the apex-lsCodeParser/PathLikeshims.SmokeTest. The npm peer dep@apexdevtools/apex-parseris bumped to^5.0.0.Changes
build.sbt: dropapex-ls 6.0.2test dep, addapex-parser 5.0.0+scala-parallel-collections 1.0.4(JVM Test scope).SampleTest,testutil/AntlrParser,testutil/ClassScannerfromshared/src/test/→jvm/src/test/.AntlrParserto useApexParserFactory.createLexer/createParserwith an inlineCollectingErrorListener.PathLikewithjava.nio.file.Paththroughout test infrastructure.js/src/test/.../AntlrOps.scala.apex-parsernpm peer todevDependency; engines bumped to matchapex-parser 5.x.CHANGELOG.mdfor 2.0.0-beta.1 (covers all 2.0 breaking changes).Test plan
sbt scalafmtCheckAllsbt buildSAMPLES=~/adt/apex-samples sbt parserJVM/test— 6314 tests passsbt parserJS/test— 52 tests pass