Skip to content

fix: prefer hydra title when available #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soyuka merged 1 commit into from
Jan 30, 2025
Merged

fix: prefer hydra title when available #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions src/hydra/parseHydraDocumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import type {
ExpandedClass,
ExpandedDoc,
Entrypoint,
ExpandedOperation,
ExpandedRdfProperty,
RequestInitExtended,
} from "./types.js";
Expand All @@ -24,6 +25,19 @@ function guessNameFromUrl(url: string, entrypointUrl: string): string {
return url.substr(entrypointUrl.length + 1);
}

function getTitleOrLabel(obj: ExpandedOperation): string {
const a =
obj["http://www.w3.org/2000/01/rdf-schema#label"] ??
obj["http://www.w3.org/ns/hydra/core#title"] ??
null;

if (a === null) {
throw new Error("No title nor label defined on this operation.");
}

return a[0]["@value"];
}

/**
* Finds the description of the class with the given id.
*/
Expand Down Expand Up @@ -279,9 +293,12 @@ export default function parseHydraDocumentation(
) as unknown as string;

const field = new Field(
supportedProperty["http://www.w3.org/2000/01/rdf-schema#label"][0][
supportedProperties["http://www.w3.org/ns/hydra/core#title"][0][
"@value"
],
] ??
supportedProperty[
"http://www.w3.org/2000/01/rdf-schema#label"
][0]["@value"],
{
id,
range,
Expand Down Expand Up @@ -369,9 +386,7 @@ export default function parseHydraDocumentation(
type = "create";
}
const operation = new Operation(
entrypointOperation[
"http://www.w3.org/2000/01/rdf-schema#label"
][0]["@value"],
getTitleOrLabel(entrypointOperation),
type,
{
method,
Expand Down Expand Up @@ -424,9 +439,7 @@ export default function parseHydraDocumentation(
type = "delete";
}
const operation = new Operation(
supportedOperation["http://www.w3.org/2000/01/rdf-schema#label"][0][
"@value"
],
getTitleOrLabel(supportedOperation),
type,
{
method,
Expand Down