fix(elasticsearch): coerce document _id to declared int identifier type#8296
Open
soyuka wants to merge 1 commit into
Open
fix(elasticsearch): coerce document _id to declared int identifier type#8296soyuka wants to merge 1 commit into
soyuka wants to merge 1 commit into
Conversation
Elasticsearch always exposes _id as a string; DocumentNormalizer wrote it verbatim into _source, so an int-typed resource identifier failed denormalization with NotNormalizableValueException. Coerce _id to int only when the declared native identifier type is int; string and UUID identifiers are left untouched. Fixes api-platform#8010
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Elasticsearch always exposes the document identifier (
_id) as a string.DocumentNormalizer::populateIdentifier()wrote that raw string into_sourceunder the resource's identifier key, so a resource whose identifier is declaredintfailed denormalization in the innerObjectNormalizerwithNotNormalizableValueException(The type of the "id" attribute ... must be one of "int" ("string" given)).The normalizer now coerces
_idto int only when the identifier's declared native type is int (and not string). String and UUID identifiers are left untouched. The coercion is type-driven viaPropertyMetadataFactoryInterface::create(...)->getNativeType(), not a blind cast; when the property metadata factory or type info is unavailable the value is returned unchanged (no behavior change).Reproduction
Denormalizing an ES document with a string
_idinto a resource whose identifier is?intthrewNotNormalizableValueExceptioninstead of building the item.Test plan
testDenormalizeCoercesIdentifierToDeclaredType(red before fix, green after).Fixes #8010