Skip to content

test(mongodb): failing repro for ODM nullable field unset #8298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soyuka wants to merge 1 commit into
base: 4.3
Choose a base branch
from
+15 −0
Open

test(mongodb): failing repro for ODM nullable field unset #8298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Doctrine/Odm/Tests/PropertyInfo/DoctrineExtractorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,21 @@ public static function typesProvider(): iterable
yield ['notMapped', null];
}

/**
* In ODM, a Field's `nullable` flag does not mean "may hold null" — it controls whether a null
* value is persisted as an explicit null key or the key is omitted from the document. Every ODM
* field can therefore receive null, so the extracted TypeInfo Type must permit null even when the
* mapping uses the default `nullable=false`. Otherwise PATCH {"field": null} is rejected with
* "The type of the ... attribute must be ..., NULL given." (issue #3746).
*/
public function testExtractScalarFieldPermitsNull(): void
{
$type = $this->createExtractor()->getType(DoctrineDummy::class, 'string');

$this->assertNotNull($type);
$this->assertTrue($type->isNullable(), 'ODM scalar fields are always nullable; the extracted type must permit null.');
}

public function testGetPropertiesCatchException(): void
{
$this->assertNull($this->createExtractor()->getProperties('Not\Exist'));
Expand Down
Loading