fix: switch packageManager devEngines to warn + add minimumReleaseAge#286
Open
B4nan wants to merge 1 commit into
Open
fix: switch packageManager devEngines to warn + add minimumReleaseAge#286B4nan wants to merge 1 commit into
B4nan wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
t-tooling
Two related supply-chain hygiene changes: 1. devEngines.packageManager.onFail: error → warn pnpm v10 still shells out to system npm for several subcommands (`pnpm version`, `pnpm config`, etc.) and several CI steps in this repo invoke npm directly (`npm install`, `npm i @octokit/...`, `npm install -g @anthropic-ai/claude-code`). With onFail:error those trip EBADDEVENGINES. `warn` keeps the visible signal without blocking. Also pins version to 10.33.0 for clarity. 2. Add minimumReleaseAge: 1440 to pnpm-workspace.yaml 24-hour quarantine on new package versions. Mitigates compromised npm packages that get discovered and yanked within the first day (shai-hulud worm, nx self-replicator, etc.). Brings this repo in line with the rest of the pnpm-migrated public repos. Mirrors the rollout in apify/apify-client-js#895 + #896.
B4nan
force-pushed
the
fix/devengines-warn-and-mra
branch
from
532f5e7 to
eac1558
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related supply-chain hygiene changes:
1.
devEngines.packageManager.onFail: error → warnpnpm v10 still shells out to system npm for several subcommands (
pnpm version,pnpm config, etc.). This repo also has direct npm invocations in CI:npm installnpm i @octokit/rest@release-19.xnpm install -g @anthropic-ai/claude-codeWith
onFail: errorthose tripEBADDEVENGINES.warnkeeps the dev-visible signal without blocking. Also pins the version to10.33.0for clarity.2. Add
minimumReleaseAge: 1440topnpm-workspace.yaml24-hour quarantine on new package versions. Mitigates compromised npm packages that get discovered and yanked within the first day (shai-hulud worm, nx self-replicator, etc.). Brings this repo in line with the rest of the pnpm-migrated public repos.
Mirrors the rollout in apify/apify-client-js#895 + #896.