feat: add python-package-check composite action#296
Open
vdusek wants to merge 2 commits into
Open
Conversation
vdusek
added
adhoc
This was referenced May 13, 2026
vdusek
force-pushed
the
feat/python-package-check-action
branch
from
05b5028 to
dfe6669
Compare
vdusek
force-pushed
the
feat/python-package-check-action
branch
from
ffe0fb0 to
9127410
Compare
janbuchar
approved these changes
May 15, 2026
Contributor
janbuchar
left a comment
janbuchar
left a comment
There was a problem hiding this comment.
Mostly fine by me, but watch out for https://github.com/apify/actions/ - perhaps you should direct the PR there 🙂
Comment on lines
+10
to
+18
| src_package_dir: | ||
| description: Path to the package source directory, relative to the repository root. | ||
| required: true | ||
| dist_dir: | ||
| description: Directory containing the built sdist + wheel. | ||
| required: true | ||
| python_version: | ||
| description: Python version to use for the verification venvs. | ||
| required: true |
Contributor
There was a problem hiding this comment.
Isn't there a sensible default for these?
Contributor
There was a problem hiding this comment.
Since we always run this with uv run, you can specify typer and rich as script dependencies and make this shorter and more readable (no arcane argparse setup, no custom stdout formatting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a composite action
python-package-checkthat verifies the sdist + wheel indist/install and import cleanly into fresh venvs, and that archive contents are correct (metadata files present, fullsrc/<pkg>tree shipped, notests//docs//uv.lockleaks). Optionalsmoke_coderuns extra assertions afterimport <pkg>.To be used after
prepare-pypi-distributionin PR checks and release flows across crawlee-python, apify-sdk-python, apify-client-python, apify-shared-python.Also adds repo-wide ruff + ty config (
pyproject.toml,uv.lock) and apython_checksCI job covering the two Python scripts now in this repo.Verified locally against built artifacts of all four Python packages.