-
Notifications
You must be signed in to change notification settings - Fork 3
feat(additional-properties): add typed additional properties support for models #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…for models This commit adds the handling for the typed additional properties in serialization (form and JSON) and de-serialization. Also, contains the tests for the newly added changes.
…ion and deserialization
hamzamahmood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the comments in the PR before it can be merged and released.
…thub.com/apimatic/core-lib-java into 105-add-typed-additional-propery-support
|
haseeb-mhr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hamzamahmood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM



What
This PR adds the handling for the typed additional properties in serialization (form and JSON) and de-serialization. Also, contains the tests for the newly added changes.
Why
To add support for the typed additional properties in the SDK
Closes #105
Type of change
Select multiple if applicable.
Dependency Change
If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries
Breaking change
If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries
Testing
List the steps that were taken to test the changes
Checklist