Parallel rspec by apiology · Pull Request #27 · apiology/solargraph

apiology · 2026-01-31T21:40:37Z

No description provided.

Fix issue revealed by more aggressive setting of debug logging

This seems to reproduce when not run in order with other specs in file

apiology · 2026-02-11T15:42:58Z

spec/diagnostics/rubocop_helpers_spec.rb

 # frozen_string_literal: true

-describe Solargraph::Diagnostics::RubocopHelpers do
+describe Solargraph::Diagnostics::RubocopHelpers, order: :defined do


This doesn't really have an effect since we haven't turned on random spec running and parallel_test splits only at the whole files level, but I thought it was better to mark the fact that these were order dependent in case we make further changes.

apiology · 2026-02-11T15:44:11Z

spec/language_server/protocol_spec.rb


-describe Protocol do
-  before :all do
+describe Protocol, order: :defined do


Ditto above - these specs are order-dependent

apiology · 2026-02-12T11:29:39Z

spec/language_server/transport/adapter_spec.rb

    expect(tester.host).to be_a(Solargraph::LanguageServer::Host)
-    expect(tester.host).not_to be_stopped
+    expect(tester.host).not_to be_fully_stopped
+    tester.host.fully_stop


With test files running in a different order than before, I was seeing issues with RuboCop (which chanes directories temporarily as part of its configuration reading) still running in the background while other specs started, leading to things running in random directories. This is intended to ensure that RuboCop has finished before moving on.

apiology · 2026-02-12T11:31:42Z

spec/type_checker/levels/strict_spec.rb

+      specs = api_map.resolve_require('kramdown-parser-gfm')
+      specs.each { |spec| api_map.cache_gem(spec) }
+      bench = Solargraph::Bench.new(source_maps: [source_map], external_requires: ['kramdown-parser-gfm'])
+      api_map.catalog bench


Trim a couple of steps off while loading this gem

apiology · 2026-02-12T11:32:26Z

spec/workspace/gemspecs_fetch_dependencies_spec.rb


      it 'finds a known dependency' do
-        expect(deps.map(&:name)).to include('backport')
+        expect(deps.map(&:name)).to include('rbs')


Try to avoid referencing the same gem in more than one area to track down concurrency issue installing/removing the backport gem.

@todos

* Improve signature combination Use our generated RBS signature from parameters as a key to combine method signatures from RBS/YARD pins. This is closer to what RBS does than the current technique of using the arity alone, and fixes a key degenerate case in Integer#+ revealed by updated definitions used by recently released RBS gems * Update annotations * Drop annotation * Fix RuboCop issue * Fix merge * Don't use solargraph-rspec branch * Fix merge * Debug * Add another use of stdlib dependencies in RBS * Mock additional call * Fix annotations * Update types in rspec undercover * Debug * Debug * Drop incorrect rbs collection use in spec * Update rubocop todo * Revert change * Fix RuboCop issue * Fix annotations * Fix annotations * RuboCop fix * Use "type arity" to guide signature combination * Update rubocop todo * Include return type arity in comparison * Add dodgy return type * Fix RuboCop issue * Add Ruby 4.0 jobs * Exclude another combo * Exclude another combo * Update rules to use report? * Fix merge * Fix merge * Drop dead code * Bump version to 0.59.0.dev.1 * Rename rule * Update RuboCop todo file * Update RuboCop todo file * Ratchet rubocop TODO file * Move to skip: * Mark spec as pending * Revert spec change * Drop old workaround * Fix merge * Fix typechecking issues * Revert doc * Fix spelling * Fix merge issue * Exclude the current gemspec from pins brought in from gem * Check pathname instead * Add sg-ignore * Avoid rbs pollution We were using the sig/shims directory for some internally helpful shims; unfortunately that exported them during gem installs, causing castwide#1144 * Test with RBS 4.0.0.dev.5 * Open up in gemspec * Fix missing spot * Typecheck using RBS prereleases * Move point of ignoring cached gems for gem projects * Fix issues resolving cgi escape functions * Be more careful marking things as stdlib * Reclassify rbs gem * Fix merge * Add sg-ignore * Fix merge * Remove outdated workaround * Fix @sg-ignore name * Restore workaround * Restore workaround * Merge branch 'flow_sensitive_typing_2_0' into 2025-01-06 * Fix method signature * Fix annotations * Add regression test and fix for issue found during future merge * Add regression test and fix for issue found during future merge * Fix merge * Fix merge * Fix merge * Fix merge * Use correct field for self type resolution Add a regression test and fix for self type resolution issue found on a future branch * Fix 'solargraph pin --references ClassName' private method call * Add error handling * Fix another location with another test case * Drop now-unneeded @sg-ignore * Don't log caching for each dependent library This causes duplicate logging on standard libraries, many of which are esoteric (e.g., "cgi-escaping"). The current method as of the 2025-01-06 branch would result in each stdlib library being cached individually. * Drop logging entirely * Fix some types based on future branch feedback * Provide Gem::Specification to outside interface * Provide Gem::Specification to outside interface * Use #to_spec * Provide Gem::Specification to outside interface * Fix typechecking error * Use consistent bundler versions * Fix type issue * Fix annotations based on future branch feedback * Add some @todos * Fix annotations * Fix annotations * Fix annotation * Add diff::lcs shim * Improve spec expectations * Add @sg-ignore * Fix rspec checks to run on all types of PRs * Fix merge * Fix merge * Fix merge * Avoid rbs pollution (castwide#1146) We were using the sig/shims directory for some internally helpful shims; unfortunately that exported them during gem installs, causing castwide#1144 * Fix 'solargraph pin --references ClassName' private method call (castwide#1150) * Manual rubocop fixes Some hand-changed fixes for RuboCop issues * RuboCop manual fixes * RuboCop manual fixes * Improve memory efficiency of Position class (castwide#1054) * Use each_line instead of text.lines Avoid allocating additional strings, instead use sliced substrings * gitignore vendor/cache * Remove redundant end_with? Co-authored-by: Jean Boussier <jean.boussier@gmail.com> * Remove benchamrks castwide#1054 (comment) * String#index(offset:) FTW 🚀 castwide#1054 (comment) Co-authored-by: Jean Boussier <jean.boussier@gmail.com> * fix rubocop --------- Co-authored-by: Jean Boussier <jean.boussier@gmail.com> * RuboCop manual fixes * RuboCop manual fixes * RuboCop manual fixes * RuboCop manual fixes * RuboCop manual fixes * RuboCop manual fixes * RuboCop manual fixes * RuboCop manual fixes * Raise InvalidOffsetError for offsets > text (castwide#1155) * Raise InvalidOffsetError for offsets > text * Linting * Fix fencepost error * Additional fencepost test * Document exception * Refactor RbsMap::Conversions Let's work more directly with type objects and reduce duplication * Release 0.58.2 * Complete other_type_to_type transition * Refactor * Refactor * Refactor * Refactor * Refactor * Refactor * Refactor * Refactor * Add @sg-ignores * Fix tuple issue * Refactor * Tuple -> Array() * Add @sg-ignore * Use rooted names, clarify intent * Refactor * Remove TODOs, add asserts * Fix solargraph-rspec spec failure * Fix merge * Adjust rubocop todo * Debug logging fixes * Reproduce build problem with RBS pre-release * Stop hard-coding bundler version * Use bundler preferred by setup-ruby step * Fix merge * rubocop -a * manual typechecking fixes * Fix indentation * Sync @sg-ignores with CI * rubocop -A * Fix typechecking issues --------- Co-authored-by: Lekë Mula <l.mula@finlink.de> Co-authored-by: Jean Boussier <jean.boussier@gmail.com> Co-authored-by: Fred Snyder <fsnyder@castwide.com>

apiology added 30 commits January 29, 2026 07:45

Add gem

5749c42

Finish Rakefile changes

2888594

Fix issue revealed by more aggressive setting of DEBUG log level

afb3fe0

Use valid values for parameters in tests

310408e

Fix issue revealed by more aggressive setting of debug logging

Add missing step in spec

750b371

This seems to reproduce when not run in order with other specs in file

Add .envrc to set number of parallel jobs

f8da41c

Add debug logging

d4a21e6

Merge branch 'better_logging_testing' into parallel_rspec

2e94d97

Rely on bundler installed by ruby/setup-ruby

70f0c5f

Merge branch 'speed_up_specs' into parallel_rspec

96ef0c5

Swap to name that prspec triggers on

7a05bb2

Set PARALLEL throughout based on number of physical cores

c26e6d6

Debug

f2b16af

Bump prspec version

0adb139

Flag individual sub-contexts for parallel_rspec

13eda65

Try ApiMap.new

a1629b5

More prspec updates

e46e6b3

Fix nil violation found in tests

dba7d29

Debug

8a4d722

Another nil fix

f8260b4

Avoid direct reference to current directory

2dabf64

Drop @sg-ignore

4949ce1

Add PROJECT_DIRECTORY to avoid chdir issues

51f34ce

Try using main api_map

dee9fb6

Try excluding

d671728

Use bundler cache more

0b8bbce

Include psych in compilation

cb976e2

Fix nil gemspecs list

9c92f57

Debug

d39049e

Debug

8dc1f38

apiology commented Feb 11, 2026

View reviewed changes

apiology added 18 commits February 11, 2026 08:54

Revert

e076205

Remove before :context

0324b2f

Revert

baa84a6

Revert

04e39b5

Try another approach to the diagnoser background thread chdir issue

d0bcb25

Fix perpetual loop

49a6d3c

Fix fully_stopped? logic

8171aa0

Avoid chdir block

2ec00a4

Log ticks

1dccd5d

Log ticks

7d9b787

Debug

df9ad9b

Log ticks

2308868

Debug

7177237

Debug

2f6e441

Debug

e7873d8

Bump timeout

90476b7

Drop a before context block

5231a27

Debug

bef158b

apiology commented Feb 12, 2026

View reviewed changes

apiology and others added 7 commits February 12, 2026 04:33

Drop prspec blocks

49faea6

Debug

5219dec

Reorg flaky spec

aea00fc

Merge remote-tracking branch 'castwide/v0.59' into parallel_rspec

b507345

Fix typechecking issue

3eb0db1

Fix merge

a74e9be

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parallel rspec#27

Parallel rspec#27
apiology wants to merge 268 commits into2026-01-31from
parallel_rspec

apiology commented Jan 31, 2026

Uh oh!

apiology Feb 11, 2026

Uh oh!

apiology Feb 11, 2026

Uh oh!

apiology Feb 12, 2026 •

edited

Loading

Uh oh!

apiology Feb 12, 2026

Uh oh!

apiology Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

apiology commented Jan 31, 2026

Uh oh!

apiology Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

apiology Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

apiology Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

apiology Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

apiology Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

apiology Feb 12, 2026 •

edited

Loading