fix: call middlewares defined after koaMiddleware#232
Open
kaioduarte wants to merge 1 commit intoapollo-server-integrations:mainfrom
Open
fix: call middlewares defined after koaMiddleware#232kaioduarte wants to merge 1 commit intoapollo-server-integrations:mainfrom
kaioduarte wants to merge 1 commit intoapollo-server-integrations:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
matthew-gordon
approved these changes
Dec 4, 2024
Collaborator
|
Looks good to me, I approved but someone with write access needs to approve as well to pass branch protections. @trevor-scheer or @BlenderDude any chance for a review and approval? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not having the
nextfunction call can cause unexpected issues on the user's codebase, like on Strapi, it prevented the authentication hook from being called if declared after this middleware.See strapi/strapi#21977